MDEV-39691 wsrep.cnf contains deprecated wsrep_causal_reads#5104
MDEV-39691 wsrep.cnf contains deprecated wsrep_causal_reads#5104grooverdan wants to merge 2 commits into
Conversation
grooverdan
added
the
MariaDB Foundation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the wsrep.cnf.sh configuration file by replacing references to 'mysqld' with 'mariadb' and 'mariadbd' to reflect the transition to MariaDB. It also removes the wsrep_causal_reads configuration option. A review comment correctly identifies a spelling error in a modified comment line and provides a suggestion to fix it.
janlindstrom
left a comment
janlindstrom
left a comment
There was a problem hiding this comment.
ok to remove wsrep_causal_read but add wsrep_sync_wait
janlindstrom
left a comment
janlindstrom
left a comment
There was a problem hiding this comment.
There is now merge <<<<< HEAD tags
|
@janlindstrom is enough, I removed myself from reviewers |
|
@janlindstrom if you've got 10.6 push access can you trigger the upgrade branch/automerge as I'm unable. |
wsrep_causal_reads was deprecated in 10.1.3 and removed in 11.3.1. Put in place the equivalent (and default) wsrep_sync_wait=0. Amend a few early comments to show MariaDB as our product.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@grooverdan I do not have powers to enable automerge but I did have powers to do update branch. |
3 participants
wsrep_causal_reads was deprecated in 10.1.3 and removed in 11.3.1.
Remove it out of the configuration file in the earliest supported version as config file are kept on upgrade.
Amend a few early comments to show MariaDB as our product.